[GH-182] Added a missing method in the Constraint interface

This issue is created automatically through a Github pull request on behalf of stof:

Message:

This adds a missing method in the Constraint interface. The method is already defined in AbstractAsset which is extended by both classes implementing the interface. the AbstractPlatform is calling this method on objects after checking they are implementing the interface. So either the method should be part of the interface, or all places using the interface as typehint should be refactored to check for the classes (examples can be found [here](https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php#L1029) and [there](https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php#L1254)).

Adding a method in an interface is technically a BC break but this method is not really a public extension point. what do you think @beberlei ?

Ascending order - Click to sort in descending order

Hide

Permalink

Benjamin Eberlei added a comment - 14/Aug/12 9:32 PM

A related Github Pull-Request [GH-182] was closed
https://github.com/doctrine/dbal/pull/182

Show

Benjamin Eberlei added a comment - 14/Aug/12 9:32 PM A related Github Pull-Request [GH-182] was closed https://github.com/doctrine/dbal/pull/182

Alexander made changes - 14/Aug/12 9:33 PM

This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DBAL-315, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

Vote (0)

Watch (1)