Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-302

[GH-168] DebugStack should ignore stopQuery when disabled

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of dpb587:

      Url: https://github.com/doctrine/dbal/pull/168

      Message:

      I noticed that DebugStack was adding an empty element when it was disabled. This PR changes it to match startQuery with its behavior.

      1) Doctrine\Tests\DBAL\Logging\DebugStackTest::testLoggedQueryDisabled
      Failed asserting that two arrays are equal.
      — Expected
      +++ Actual
      @@ @@
      Array
      (
      + [0] => Array
      + (
      + [executionMS] => 1341871660.9651
      + )
      +
      )

      I've submitted the PR to 2.0.x since that's where the bug is first seen and is still listed as stable on doctrine-project.org. Preferably this could also be applied to newer branches as well, or I can also submit separate PRs.

        Activity

        Hide
        Benjamin Eberlei added a comment -

        A related Github Pull-Request [GH-168] was closed
        https://github.com/doctrine/dbal/pull/168

        Show
        Benjamin Eberlei added a comment - A related Github Pull-Request [GH-168] was closed https://github.com/doctrine/dbal/pull/168

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Benjamin Eberlei
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: