Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-262

[GH-136] Support oci8 in TableGenerator

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of dpb587:

      Url: https://github.com/doctrine/dbal/pull/136

      Message:

      Bug fix: yes
      Feature addition: no
      Backwards compatibility break: no
      [![Build Status](https://secure.travis-ci.org/dpb587/dbal.png?branch=bugfix-TableGenerator)](http://travis-ci.org/dpb587/dbal)

      This test was breaking when running under `oci8` due to Oracle's deference to upper case column names. I realize Oracle has built-in sequences and `TableGenerator` is unnecessary, in theory, but it seemed like the class should work if possible. I see pgsql is in the same boat.

      Tested with:

      phpunit -c oci8.phpunit.xml.dist tests/Doctrine/Tests/DBAL/Functional/TableGeneratorTest.php

      Before:

      PHPUnit 3.5.13 by Sebastian Bergmann.

      EE

      Time: 0 seconds, Memory: 10.25Mb

      There were 2 errors:

      1) Doctrine\Tests\DBAL\Functional\TableGeneratorTest::testNextVal
      Exception: [Doctrine\DBAL\DBALException] Error occured while generating ID with TableGenerator, aborted generation: Undefined index: sequence_value

      2) Doctrine\Tests\DBAL\Functional\TableGeneratorTest::testNextValNotAffectedByOuterTransactions
      Exception: [Doctrine\DBAL\DBALException] Error occured while generating ID with TableGenerator, aborted generation: Undefined index: sequence_value

      After:

      PHPUnit 3.5.13 by Sebastian Bergmann.

      ..

      Time: 1 second, Memory: 10.25Mb

      OK (2 tests, 5 assertions)

        Activity

        Benjamin Eberlei created issue -
        Hide
        Benjamin Eberlei added a comment -

        Fixed

        Show
        Benjamin Eberlei added a comment - Fixed
        Benjamin Eberlei made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.3 [ 10184 ]
        Resolution Fixed [ 1 ]
        Hide
        Benjamin Eberlei added a comment -

        A related Github Pull-Request [GH-136] was closed
        https://github.com/doctrine/dbal/pull/136

        Show
        Benjamin Eberlei added a comment - A related Github Pull-Request [GH-136] was closed https://github.com/doctrine/dbal/pull/136
        Benjamin Eberlei made changes -
        Workflow jira [ 13665 ] jira-feedback2 [ 17819 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback2 [ 17819 ] jira-feedback3 [ 20174 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DBAL-262, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Benjamin Eberlei
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: