Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-195

Method AbstractSchemaManager->dropAndCreateSequence() contains erroneous code.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.5
    • Fix Version/s: 2.1.6, 2.2
    • Component/s: Schema Managers
    • Security Level: All
    • Labels:
      None

      Description

      I needed to use the function and looking at the code I found that it seemed partially implemented, cut and pasted from something else or just not ported from an earlier implementation. I'm now submitting a patch that fixes this issue. I didn't modify the AbstractSchemaManager->dropSequence($name) signature to become AbstractSchemaManager->dropSequence($sequence) but it might be a good idea to refactor it (guess that would be another issue though )

        Activity

        Marc Campeau created issue -
        Hide
        Benjamin Eberlei added a comment -

        Oh the code worked before, but was refactored. This method was forgotten.

        Show
        Benjamin Eberlei added a comment - Oh the code worked before, but was refactored. This method was forgotten.
        Hide
        Benjamin Eberlei added a comment -

        Fixed.

        Show
        Benjamin Eberlei added a comment - Fixed.
        Benjamin Eberlei made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.1.6 [ 10181 ]
        Fix Version/s 2.2 [ 10142 ]
        Fix Version/s 2.1.5 [ 10167 ]
        Resolution Fixed [ 1 ]
        Benjamin Eberlei made changes -
        Workflow jira [ 13337 ] jira-feedback2 [ 17775 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback2 [ 17775 ] jira-feedback3 [ 20130 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DBAL-195, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Marc Campeau
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: