Doctrine DBAL

Documentation states that Doctrine 'decimal' (DecimalType) is mapped to PHP 'double', however, string is returned

Details

  • Type: Documentation Documentation
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 2.1.2
  • Fix Version/s: None
  • Component/s: None
  • Security Level: All
  • Labels:
    None

Description

At http://www.doctrine-project.org/docs/orm/2.1/en/reference/basic-mapping.html#doctrine-mapping-types, it is stated that:

"decimal: Type that maps an SQL DECIMAL to a PHP double."

However, in the commit history, we can see that the casting to a float is removed: https://github.com/doctrine/dbal/commits/master/lib/Doctrine/DBAL/Types/DecimalType.php. Casting to a double is not possible in PHP?This seems to result in a float as well, that is probably why it was removed.

I found this out when using PHP's 'is_double()' function (alias of is_float()) to check whether a decimal property was set or not.

Suggestion is to either:

  • cast to a double (which seems not possible)
  • cast to a float (why was this removed?)
  • do nothing to the code, update documentation that string is returned.

In my check function I guess I will use the is_numeric() function.

Activity

Descending order - Click to sort in ascending order
Hide
Permalink
karlie verkest added a comment -

There may be other issues around comparison. I'd rather be comparing numeric types than strings when comparing "decimal" values.

Show
karlie verkest added a comment - There may be other issues around comparison. I'd rather be comparing numeric types than strings when comparing "decimal" values.
Hide
Permalink
Oleg Namaka added a comment -

Leaving decimal values as strings creates another issue with unnecessary entity updates because old and new same values have different types: old value is always the string type, the new one - decimal. If an old value is '10.00' as a string and the new value is 10 decimal than Doctrine will issue the UPDATE statement for that entity. This is plainly wrong IMHO.

Show
Oleg Namaka added a comment - Leaving decimal values as strings creates another issue with unnecessary entity updates because old and new same values have different types: old value is always the string type, the new one - decimal. If an old value is '10.00' as a string and the new value is 10 decimal than Doctrine will issue the UPDATE statement for that entity. This is plainly wrong IMHO.
Hide
Permalink
Patrick McDougle added a comment - - edited

I have submitted a pull request on this issue on github. Hopefully the doc will be updated soon so other people don't expect the wrong behavior!

https://github.com/doctrine/orm-documentation/pull/93

Mods, this issue can probably be closed.

Show
Patrick McDougle added a comment - - edited I have submitted a pull request on this issue on github. Hopefully the doc will be updated soon so other people don't expect the wrong behavior! https://github.com/doctrine/orm-documentation/pull/93 Mods, this issue can probably be closed.
Hide
Permalink
Roel Harbers added a comment -

I would strongly suggest to leave the behaviour as-is, and fix the documentation, because of all the trouble associated with floating point and rounding. People use the DECIMAL type to prevent those issues, so having the ORM convert it to floating point again would be pretty bad.

Show
Roel Harbers added a comment - I would strongly suggest to leave the behaviour as-is, and fix the documentation, because of all the trouble associated with floating point and rounding. People use the DECIMAL type to prevent those issues, so having the ORM convert it to floating point again would be pretty bad.

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Menno Holtkamp
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: