Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-BETA3
    • Component/s: None
    • Labels:
      None

      Description

      The SqlLogger currently has a very simple API, which lacks for example the possibilty to log the execution time of queries. This would require a second call of the logger however, but i made some performance tests on the current implementation. Its using the following check to look if logging is enabled:

      if($this->_config->getSqlLogger())
      

      However:

      if($this->_hasLogger)
      

      Only takes half the time. See the test at the bottom.

      We could switch to a boolean flag and use the "saved" time to enhance the SQL Logger API to include the following information:

      1. SQL (Have already)
      2. Params (Have already)
      3. Elapsed Time (Start Time and End Time)
      4. Query Type (SELECT, INSERT, UPDATE, DELETE, OTHER)

      This would benefit both Symfony and ZF since they could hook into the logger for their respective debugging facilities (sf Web Toolbar, Zend Firebug SQL Profiling).

      <?php                                                                                             
      class Config                                                                                      
      {                                                                                                 
          protected $_logger;                                                                           
          public function __construct()                                                                 
          {                                                                                             
              $this->_logger = new stdClass();
          }
          public function getLogger()
          {
              return $this->_logger;
          }
      }
      
      class Foo
      {
          protected $_config = null;
          public function __construct()
          {
               $this->_config = new Config();
          }
          public function execute()
          {
               if($this->_config->getLogger()) {
               }
          }
      }
      
      class Bar
      {
          protected $_config = null;
          protected $_loggerExists = false;
          public function __construct()
          {
               $this->_config = new stdClass();
               $this->_loggerExists = true;
          }
          public function execute()
          {
              if($this->_loggerExists) {
      
              }
          }
      }
      
      $f = new Foo();
      $s = microtime(true);
      for($i = 0; $i < 100; $i++) {
          $f->execute();
      }
      echo (microtime(true)-$s)."s\n";
      
      $f = new Bar();
      $s = microtime(true);
      for($i = 0; $i < 100; $i++) {
          $f->execute();
      }
      echo (microtime(true)-$s)."s\n"
      
      benny@benny-pc:~/code/php/wsnetbeans/Doctrine/trunk/tests$ php /tmp/boolvsmethod.php                
      0.00055313110351562s                                                                                  
      0.00025200843811035s                                                                                  
      benny@benny-pc:~/code/php/wsnetbeans/Doctrine/trunk/tests$ php /tmp/boolvsmethod.php                
      0.00051999092102051s                                                                                
      0.00025200843811035s                                                                                
      benny@benny-pc:~/code/php/wsnetbeans/Doctrine/trunk/tests$ php /tmp/boolvsmethod.php                
      0.00036001205444336s                                                                                
      0.00017309188842773s                                                                                
      benny@benny-pc:~/code/php/wsnetbeans/Doctrine/trunk/tests$ php /tmp/boolvsmethod.php                
      0.0005180835723877s                                                                                 
      0.00025010108947754s 
      

        Activity

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Benjamin Eberlei
          • Votes:
            3 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: