Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-118

When speaking about security do not rely on default link in mysql_* function calls

    Details

    • Type: Documentation Documentation
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.5
    • Component/s: None
    • Labels:
      None

      Description

      The documentation about escaping reads:

      "Consider the previous query, now parameterized to fetch only a single article by id. Using ext/mysql (still the primary choice of MySQL access for many developers) you had to escape every value passed into the query using mysql_real_escape_string() to avoid SQL injection:

      <?php
      $sql = "SELECT * FROM articles WHERE id = '" . mysql_real_escape_string($id) . "'";
      $rs = mysql_query($sql);",
      http://www.doctrine-project.org/docs/dbal/2.0/en/reference/data-retrieval-and-manipulation.html

      Please, do not rely on MySQL default links when discussing security issues. One of major differences between the mysql and the later mysqli extension is that mysqli forces users to explicitly specify a connection handle. There is no concept of default links and magical global connection handles in mysqli any more. The convenience of not having to specify a connection handle has been removed from mysqli. This was done to increase security, for example, when escaping strings. Escaping needs to take the current charset of the connection into account. Thus, it is recommended to explicitly specify the connection and so not use default connection.

      "string mysql_real_escape_string ( string $unescaped_string [, resource $link_identifier ] )",
      http://de.php.net/mysql_real_escape_string

      Please, change the example:

      <?php
      $sql = "SELECT * FROM articles WHERE id = '" . mysql_real_escape_string($id, $link) . "'";
      $rs = mysql_query($sql);",

      ($link added)

      Thanks!

        Activity

        Hide
        Benjamin Eberlei added a comment -

        Changed, the new docs will be rolled up sometime this weekend.

        Show
        Benjamin Eberlei added a comment - Changed, the new docs will be rolled up sometime this weekend.

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Ulf Wendel
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: